summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2008-11-12 Clean up #includes according to the GNOME Goal.Thomas James Alexander Thurman11-19/+12
Closes #560449. Patch is 122467. * src/core/place.c: * src/ui/draw-workspace.h: * src/ui/gradient.h: * src/ui/metaaccellabel.c: * src/ui/metaaccellabel.h: * src/ui/preview-widget.c: * src/ui/preview-widget.h: * src/ui/resizepopup.c: * src/ui/theme.c: * src/ui/theme.h: * src/ui/themewidget.h: svn path=/trunk/; revision=4017
2008-11-10updated description of raise_on_click:Thomas James Alexander Thurman1-0/+19
* src/metacity.schemas.in.in: updated description of raise_on_click: http://bugzilla.gnome.org/show_bug.cgi?id=445447#c6 svn path=/trunk/; revision=4016
2008-11-08added dependency on Zenity remove error_on_generic_command() andThomas James Alexander Thurman3-67/+118
* configure.in: added dependency on Zenity * src/core/keybindings.c: remove error_on_generic_command() and error_on_terminal_command(); rewrite error_on_command in terms of meta_show_dialog() * src/core/util.c: add meta_show_dialog() to call Zenity * src/include/util.h: ditto svn path=/trunk/; revision=4013
2008-11-02Fix build by readding accidentally removed '}'.Olav Vitters1-0/+1
* src/ui/theme-parser.c: Fix build by readding accidentally removed '}'. svn path=/trunk/; revision=4010
2008-10-29variable names in messages should be double-quoted. Closes #558309.Thomas James Alexander Thurman1-4/+3
* src/ui/theme-parser.c: variable names in messages should be double-quoted. Closes #558309. svn path=/trunk/; revision=4009
2008-10-28fix accidental name change of run_command_terminal. Closes #557943.Thomas James Alexander Thurman1-1/+1
* src/include/screen-bindings.h: fix accidental name change of run_command_terminal. Closes #557943. svn path=/trunk/; revision=4008
2008-10-27Add initialisation which I missed on the previous checkin. Also an extraThomas Thurman1-2/+5
2008-10-27 Thomas Thurman <tthurman@gnome.org> * src/core/prefs.c (titlebar_handler, handle_preference_update_enum): Add initialisation which I missed on the previous checkin. Also an extra comment. svn path=/trunk/; revision=4004
2008-10-27Fix some crashes with the new GDM 2.24. Closes #558058.Brian Cameron2-7/+9
2008-10-27 Brian Cameron <brian.cameron@sun.com> Fix some crashes with the new GDM 2.24. Closes #558058. * src/ui/ui.c (meta_ui_parse_modifier): another null check * src/core/prefs.c (titlebar_handler, button_layout_handler): more null checks. svn path=/trunk/; revision=4003
2008-10-26Ignore values of .../mouse_button_modifier key if the key's missing.Thomas Thurman1-1/+1
2008-10-26 Thomas Thurman <tthurman@gnome.org> * src/core/prefs.c (mouse_button_mods_handler): Ignore values of .../mouse_button_modifier key if the key's missing. Closes Launchpad bug #258054, Launchpad bug #266929. svn path=/trunk/; revision=4001
2008-10-23fix stupid thinko which caused defaults to be incorrect "space" needs toThomas Thurman2-17/+2
2008-10-23 Thomas Thurman <tthurman@gnome.org> * src/core/schema-bindings.c: fix stupid thinko which caused defaults to be incorrect * src/include/window-bindings.h: "space" needs to be lowercase svn path=/trunk/; revision=3992
2008-10-23Support _NET_WM_STATE_STICKY (i.e. allow third-party apps to decideThomas Thurman3-4/+22
2008-10-23 Thomas Thurman <tthurman@gnome.org> Support _NET_WM_STATE_STICKY (i.e. allow third-party apps to decide whether a window is on all workspaces). Bug found by Ka-Hing Cheung. Closes #557536. * src/core/window.c (set_net_wm_state): report it * src/core/window.c (meta_window_client_message): set sticky if we receive it * src/core/window-props.c: set sticky if we find it * src/core/atomnames.h: add _NET_WM_STATE_STICKY svn path=/trunk/; revision=3991
2008-10-23support builds outside tree properly. ditto.Thomas Thurman1-4/+5
2008-10-22 Thomas Thurman <tthurman@gnome.org> * src/core/schema-bindings.c: support builds outside tree properly. * src/Makefile.am: ditto. svn path=/trunk/; revision=3989
2008-10-23support builds outside tree properly.Thomas Thurman1-24/+50
2008-10-22 Thomas Thurman <tthurman@gnome.org> * src/core/schema-bindings.c: support builds outside tree properly. svn path=/trunk/; revision=3988
2008-10-22Fixes to make distcheck work again.Thomas Thurman1-4/+6
2008-10-22 Thomas Thurman <tthurman@gnome.org> Fixes to make distcheck work again. * src/Makefile.am: include *-binding.h, and make the schema building work when builddir != srcdir * po/POTFILES.in (src/core/keybindings.): include *-binding.h svn path=/trunk/; revision=3985
2008-10-222.25.2 release.Thomas James Alexander Thurman2-0/+0
svn path=/trunk/; revision=3977
2008-10-22new functions add sigterm_handler in case we receive a SIGTERM. ClosesJoe Marcus Clarke1-6/+25
2008-10-22 Joe Marcus Clarke <marcus@freebsd.org> * src/core/main.c (meta_finalize, sigterm_handler): new functions * src/core/main.c (main): add sigterm_handler in case we receive a SIGTERM. Closes #553980. svn path=/trunk/; revision=3974
2008-10-22minimised windows are necessarily obscured.Thomas Thurman1-12/+21
2008-10-22 Thomas Thurman <tthurman@gnome.org> * src/core/window.c (meta_window_set_demands_attention): minimised windows are necessarily obscured. svn path=/trunk/; revision=3971
2008-10-22Slight transformation of the x-macros used in keybindings to make themThomas Thurman5-373/+285
2008-10-22 Thomas Thurman <tthurman@gnome.org> Slight transformation of the x-macros used in keybindings to make them clearer: write handler names out in full because the old suffix system was confusing to people skim-reading, and switched the order of the last two parameters so more would generally fit on a screen. * src/core/keybindings.c, src/core/schema-bindings.c src/core/prefs.c: sympathy changes * src/core/window-bindings.h, src/core/screen-bindings.h: transformation as above svn path=/trunk/; revision=3970
2008-10-21fix build when schemas are not installed. Closes #557335.Christian Persch1-3/+0
2008-10-21 Christian Persch <chpe@gnome.org> * src/Makefile.am: fix build when schemas are not installed. Closes #557335. svn path=/trunk/; revision=3969
2008-10-21Fix off-by-one error. Fix off-by-one error. Closes #557201.Tomas Frydrych2-24/+24
2008-10-21 Tomas Frydrych <tf@linux.intel.com> * src/core/screen-bindings.h: Fix off-by-one error. * src/core/window-bindings.h: Fix off-by-one error. Closes #557201. svn path=/trunk/; revision=3968
2008-10-18During a discussion with Rodney Dawes about making life easier for theThomas Thurman5-344/+209
2008-10-18 Thomas Thurman <tthurman@gnome.org> During a discussion with Rodney Dawes about making life easier for the translators, he pointed out that the short and long forms of almost all the keybindings say much the same thing in different words. I believe this is an unconscionable burden to place on translators, and have therefore merged the short and long descriptions into the short description. The long is now a general explanation of the format, plus possibly a notice about reversibility. Closes #469361, and should solve the l10n issue previously mentioned. * src/core/keybindings.c: reflect changes in *-bindings.h * src/core/schema-bindings.c: reflect changes in *-bindings.h * src/core/prefs.c: reflect changes in *-bindings.h * src/core/window-bindings.h: Add flags field, always the same currently, so that it's the same as screen-bindings.h. Also, lose ONLY_BOUND_BY_DEFAULT, since we already had a rather more elegant way to perform the same effect. And merge the long and short descriptions. * src/core/screen-bindings.h (, item): Merge the long and short descriptions. svn path=/trunk/; revision=3966
2008-10-15Since Patrick Niklaus's checkin of 2008-08-14 dealt with windows with noThomas Thurman5-77/+11
2008-10-15 Thomas Thurman <tthurman@gnome.org> Since Patrick Niklaus's checkin of 2008-08-14 dealt with windows with no icons not using fallback icons, we don't need fallback icons. * src/ui/theme.h: remove fallback icons from struct. * src/core/iconcache.c (meta_read_icons): don't look for fallbacks. * src/*/ui.[ch] (meta_ui_get_fallback_icons): removed * src/ui/theme-parser.c (typedef, parse_toplevel_element): don't parse fallback specifications. svn path=/trunk/; revision=3958
2008-10-12Make the bindings in src/core/*-bindings.h generate GConf schemas too.Thomas Thurman5-2343/+584
2008-10-12 Thomas Thurman <tthurman@gnome.org> Make the bindings in src/core/*-bindings.h generate GConf schemas too. Note that there's an i18n issue (documented in schema-bindings.c) which will be fixed next checkin. * src/core/schema-bindings.c: major fixup to make it ready for use as part of the actual build process. * src/Makefile.am: added magic to make it call schema-bindings after it builds it. * src/core/window-bindings.h: added comments; also, window menu was listed variously as alt-Space and alt-Print; it should have been alt-Space. * src/metacity.schemas.in.in: renamed from s/\.in$//, sentinel added for the generated bindings, warning at the top now untrue, and removed. svn path=/trunk/; revision=3952
2008-10-12Fix annoying bug where alt-tab and friends would jump backwards a space onThomas Thurman1-7/+12
2008-10-12 Thomas Thurman <tthurman@gnome.org> Fix annoying bug where alt-tab and friends would jump backwards a space on initial movement. * src/core/screen-bindings.h: although reversed bindings are necessarily reversible, don't set both bits in the constant, or when we test for them we'll get confused. svn path=/trunk/; revision=3950
2008-10-12An attempt to make life a little easier for our beloved translators; thisThomas Thurman4-693/+127
2008-10-12 Thomas Thurman <tthurman@gnome.org> An attempt to make life a little easier for our beloved translators; this has the same behaviour as before, but removes over thirty translation strings. * src/core/session.c (start_element_handler): all "attribute not found on element" strings are identical * src/ui/theme-parser.c (locate_attributes): allow attribute names to be preceded with "!" (in the code) to show they're required. (parse_aspect_ratio, parse_distance, parse_toplevel_element, parse_style_element, parse_gradient_element, static, parse_border, parse_style_set_element, parse_draw_op_element): use the new "!" prefix for locate_attributes(), or in some cases just the identical constant, for generating this error. * src/ui/theme.c (check_state, meta_theme_validate): add translator comments * src/ui/resizepopup.c (update_size_window): add translator comments svn path=/trunk/; revision=3949
2008-10-06Pass modified mouse button events down to panel windows instead of dealingWilliam Lachance2-4/+10
2008-10-06 William Lachance <wrlach@gmail.com> Pass modified mouse button events down to panel windows instead of dealing with them ourselves. Closes #554428. * src/core/display.c (prefs_changed_callback): don't grab mouse buttons on panels * src/core/window.c (meta_window_new_with_attrs): ditto svn path=/trunk/; revision=3942
2008-10-06Second half of the switch to using x-macros for keybindings so that weThomas Thurman6-437/+497
2008-10-05 Thomas Thurman <tthurman@gnome.org> Second half of the switch to using x-macros for keybindings so that we don't have lots of places with the same information which must stay in the same order. This time it's screen bindings. * src/core/screen-bindings.h: New file, containing screen bindings. * src/core/schema-bindings.c: added ability to output screen bindings. * src/core/window-bindings.h: tiny tweak to comment * src/core/keybindings.c: generate function prototypes using s-b.h; several handlers modified to use ints rather than ints cast into pointers, or renamed. * src/include/prefs.h: generate names of bindings using s-b.h; generate screen_handlers using s-b.h; arguments to bindings are ints and not ints cast to pointers; several handler functions renamed to consistent names. * src/core/prefs.c (meta_prefs_set_num_workspaces, init_bindings): generate screen_handlers using s-b.h; generate screen_string_bindings using s-b.h (and add check for null bindings in init_bindings to enable this simply). svn path=/trunk/; revision=3941
2008-09-12Install desktop files in both .../share/applications andVincent Untz3-2/+31
2008-09-12 Vincent Untz <vuntz@gnome.org> Install desktop files in both .../share/applications and .../share/gnome/wm-properties. Copied in from the 2.23.x branch. Closes #549479. * src/metacity-wm.desktop.in: new file * src/.cvsignore: include the above * src/Makefile.am: install the above svn path=/trunk/; revision=3886
2008-09-06An attempt to keep all information about window bindings in the sameThomas Thurman6-361/+464
2008-09-06 Thomas Thurman <tthurman@gnome.org> An attempt to keep all information about window bindings in the same place. Screen bindings to come. * src/core/window-bindings.h: new file, list of all window bindings * src/include/prefs.h: drop all the existing window-binding macros * src/core/schema-bindings.c (): output all the schema blocks that would appear in metacity.schema for these window bindings. This ought to become part of the build process, and hopefully will soon. When this works it will also close #469361. * src/core/keybindings.c: generate handle_* prototypes using x-macros; populate window_handlers using x-macros; rename several functions to have consistent names; do_handle_move_to_workspace(), handle_move_to_workspace_flip(), and handle_move_to_workspace() all merged into handle_move_to_workspace. * src/core/prefs.c: generate window_bindings and window_string_bindings using x-macros; (meta_prefs_set_compositing_manager) fix unrelated problem with use of GConf functions when GConf was disabled. * src/core/core.c (meta_core_get_menu_accelerator): binding names given as literals since this is the only place in the code they now appear svn path=/trunk/; revision=3860
2008-09-03removed invalid "Window Manager" group at request of Matthias Clasen.Thomas Thurman1-3/+0
2008-09-03 Thomas Thurman <tthurman@gnome.org> * src/metacity.desktop.in: removed invalid "Window Manager" group at request of Matthias Clasen. svn path=/trunk/; revision=3851
2008-09-02Desktop file moved, according to policy change. Closes #549479.Thomas Thurman2-1/+2
2008-09-02 Thomas Thurman <tthurman@gnome.org> Desktop file moved, according to policy change. Closes #549479. * src/metacity.desktop.in: Don't display the desktop file * src/Makefile.am: Desktop file goes in apps directory svn path=/trunk/; revision=3846
2008-09-01When a workspace's list of struts is freed, free the struts too. ClosesThomas Thurman1-3/+28
2008-09-01 Thomas Thurman <tthurman@gnome.org> * src/core/workspace.c: When a workspace's list of struts is freed, free the struts too. Closes #549952, and #468075. svn path=/trunk/; revision=3840
2008-09-01Add new move_to_center keybinding, requested by Khanh-Dang Nguyen Thu Lam;Thomas Thurman4-0/+62
2008-09-01 Thomas Thurman <tthurman@gnome.org> Add new move_to_center keybinding, requested by Khanh-Dang Nguyen Thu Lam; closes #549979. * src/include/prefs.h (void): add name of new binding * src/core/prefs.c: added pref for it * src/core/keybindings.c (handle_move_to_center): new function * src/metacity.schemas.in: included new binding svn path=/trunk/; revision=3839
2008-08-31new function. turn the compositing manager on or off as necessary.Thomas Thurman3-3/+54
2008-08-31 Thomas Thurman <tthurman@gnome.org> * src/core/prefs.[ch] (meta_prefs_set_compositing_manager): new function. * src/core/main.c (meta_parse_options): turn the compositing manager on or off as necessary. svn path=/trunk/; revision=3838
2008-08-30moving all messages about properties to the top, as a start at #549886Thomas Thurman1-32/+11
2008-08-30 Thomas Thurman <tthurman@gnome.org> * src/core/window.c (process_property_notify): moving all messages about properties to the top, as a start at #549886 svn path=/trunk/; revision=3837
2008-08-18Adding doxygen headers to some files.Thomas Thurman8-18/+53
2008-08-18 Thomas Thurman <tthurman@gnome.org> Adding doxygen headers to some files. * src/core/metacity-Xatomtype.h * src/core/main.c * src/core/screen-private.h * src/core/window-private.h * src/core/keybindings.h * src/core/session.h * src/core/workspace.h * src/core/window-props.h () svn path=/trunk/; revision=3818
2008-08-18add a copy of each strut in a window to the workspace's strut list,Eric Piel1-2/+5
2008-08-18 Eric Piel <e.a.b.piel@tudelft.nl> * src/core/workspace.c (ensure_work_areas_validated): add a copy of each strut in a window to the workspace's strut list, instead of using the copy in the list (which would mean it was double-freed). Believed to fix #468075. svn path=/trunk/; revision=3817
2008-08-16Ensure the user_rect is set sanely for windows that start maximized.Ted Percival1-12/+28
2008-08-16 Ted Percival <ted@midg3t.net> Ensure the user_rect is set sanely for windows that start maximized. Prevents maximized windows from warping across the screen. Fixes bug #504692. * src/core/window.c (save_user_placement): renamed version of meta_window_save_user_rect(). * src/core/window.c (force_save_user_placement): similar, but will always save user_rect even if the window is maximised or fullscreen. * src/core/window.c (meta_window_move_resize_internal): unplaced windows have force_save_user_placement() called instead of save_user_placement(). svn path=/trunk/; revision=3816
2008-08-14Icons for windows are taken from the desktop theme, not from the MetacityPatrick Niklaus4-45/+73
2008-08-14 Patrick Niklaus <marex@compiz-fusion.org> Icons for windows are taken from the desktop theme, not from the Metacity theme or from the fallback icon that Metacity provided. Closes #524343. * src/ui/ui.c: Use GtkIconTheme to load the default window icon. Assumes the existence of an icon called "window", otherwise falls back to "gtk-missing-image". Fixes #524343. * src/ui/preview-widget: See above. * src/include/common.h: Add META_DEFAULT_ICON_NAME. * src/Makefile.am: Remove default_icon.png from inlinepixbufs.h. * src/default_icon.png: Removed. svn path=/trunk/; revision=3812
2008-07-14meta_display_screen_for_root() can return NULL, so check for that. FixesThomas Thurman1-9/+18
2008-07-13 Thomas Thurman <tthurman@gnome.org> * src/core/display.c (event_callback): meta_display_screen_for_root() can return NULL, so check for that. Fixes #422242. Also tidying. svn path=/trunk/; revision=3788
2008-07-13Don't attempt to double-free struts, edges and regions if work areas haveElijah Newren1-7/+17
2008-07-13 Elijah Newren <newren gmail com> * src/core/workspace.c (meta_workspace_free): Don't attempt to double-free struts, edges and regions if work areas have already been invalidated at the time of freeing a workspace. Possible fix to #361804. svn path=/trunk/; revision=3787
2008-07-13Don't allocate memory for log messages unless we're logging.Thomas Thurman1-6/+9
2008-07-12 Thomas Thurman <tthurman@gnome.org> * src/core/constraints.c (do_screen_and_xinerama_relative_constraints): Don't allocate memory for log messages unless we're logging. svn path=/trunk/; revision=3786
2008-07-13This function can now officially return NULL. Two windows can't belong toThomas Thurman2-4/+6
2008-07-12 Thomas Thurman <tthurman@gnome.org> * src/core/group.c (meta_window_get_group): This function can now officially return NULL. * src/core/window.c (meta_window_same_application): Two windows can't belong to the same application unless they both belong to some application. (Both belonging to no application is not the same.) Closes #453022. svn path=/trunk/; revision=3785
2008-06-302008-06-30 Thomas Thurman <tthurman@gnome.orgThomas James Alexander Thurman1-1/+9
* src/core/bell.c (meta_bell_set_audible): Fix typo that slipped through. svn path=/trunk/; revision=3778
2008-06-30Move comments for non-statics from the .c to .h. adapt better for C, andThomas Thurman2-60/+75
2008-06-30 Thomas Thurman <tthurman@gnome.org> * src/core/bell.[ch]: Move comments for non-statics from the .c to .h. * Doxyfile: adapt better for C, and make quiet. svn path=/trunk/; revision=3777
2008-06-30display the theme name in the title bar. Closes #430198.Thomas Thurman1-0/+19
2008-06-30 Thomas Thurman <tthurman@gnome.org> * src/ui/theme-viewer.c (main): display the theme name in the title bar. Closes #430198. svn path=/trunk/; revision=3776
2008-06-29Allow toggling of non-compositor effects (since there's a non-Metacity keyThomas Thurman3-2/+22
2008-06-29 Thomas Thurman <tthurman@gnome.org> Allow toggling of non-compositor effects (since there's a non-Metacity key to do so: /desktop/gnome/interface/enable_animations). Closes #92867. * src/include/prefs.h: add META_PREFS_GNOME_ANIMATIONS key and meta_prefs_get_gnome_animations() function * src/include/prefs.c: added meta_prefs_get_gnome_animations() function, and made supporting changes to structs. * src/core/effects.c (run_handler): checked whether enable_animations is set before running an effect. * src/core/effects.c (meta_effect_run_minimize): remove debug message. svn path=/trunk/; revision=3775
2008-06-29remove meta_ prefix on all static functions.Thomas Thurman1-25/+23
2008-06-29 Thomas Thurman <tthurman@gnome.org> * src/core/bell.c: remove meta_ prefix on all static functions. svn path=/trunk/; revision=3774
2008-06-29lose meta prefix since it's static. replace our own cast with glib macroThomas Thurman1-28/+41
2008-06-29 Thomas Thurman <tthurman@gnome.org> * src/core/stack.c (stack_sync_to_server): lose meta prefix since it's static. * src/core/stack.c (meta_stack_remove, stack_do_window_deletions): replace our own cast with glib macro designed to do the same thing svn path=/trunk/; revision=3773
2008-06-29add checks for HAVE_SHAPE where appropriate. fix type error which wasThomas Thurman3-1/+5
2008-06-28 Thomas Thurman <tthurman@gnome.org> * src/core/display.c, src/compositor/compositor-xrender.c: add checks for HAVE_SHAPE where appropriate. * src/core/xprops.c: fix type error which was causing warnings. svn path=/trunk/; revision=3772