summaryrefslogtreecommitdiff
authorSam Spilsbury <smspillaz@gmail.com>2009-11-28 05:45:10 (GMT)
committer Sam Spilsbury <smspillaz@gmail.com>2009-11-28 05:45:10 (GMT)
commit0fbe57b1697b49441ffd7c7c6062ca7a50111e6d (patch) (side-by-side diff)
tree7e21ad31143e311beef3cecdfa59eff28639aaff
parenta155a5303f0ed9d8c6dfc8a833fe8af29a47cbea (diff)
downloadelements-0fbe57b1697b49441ffd7c7c6062ca7a50111e6d.tar.gz
elements-0fbe57b1697b49441ffd7c7c6062ca7a50111e6d.tar.bz2
Only traverse references to plugin options - do not create copies
-rw-r--r--plugins/autumn/src/autumn.cpp4
-rw-r--r--plugins/bubbles/src/bubbles.cpp4
-rw-r--r--plugins/fireflies/src/fireflies.cpp4
-rw-r--r--plugins/snow/src/snow.cpp4
-rw-r--r--plugins/stars/src/stars.cpp4
5 files changed, 5 insertions, 15 deletions
diff --git a/plugins/autumn/src/autumn.cpp b/plugins/autumn/src/autumn.cpp
index 3473ca1..1dd6603 100644
--- a/plugins/autumn/src/autumn.cpp
+++ b/plugins/autumn/src/autumn.cpp
@@ -100,9 +100,7 @@ AutumnScreen::toggle (CompAction *action,
if (!p)
return true;
- options = p->vTable->getOptions ();
-
- foreach (CompOption opt, options)
+ foreach (CompOption &opt, p->vTable->getOptions ())
{
if (opt.type () == CompOption::TypeAction &&
opt.name () == "toggle_name")
diff --git a/plugins/bubbles/src/bubbles.cpp b/plugins/bubbles/src/bubbles.cpp
index 59ef17e..bddd1ef 100644
--- a/plugins/bubbles/src/bubbles.cpp
+++ b/plugins/bubbles/src/bubbles.cpp
@@ -91,9 +91,7 @@ BubbleScreen::toggle (CompAction *action,
if (!p)
return true;
- options = p->vTable->getOptions ();
-
- foreach (CompOption opt, options)
+ foreach (CompOption &opt, p->vTable->getOptions ())
{
if (opt.type () == CompOption::TypeAction &&
opt.name () == "toggle_name")
diff --git a/plugins/fireflies/src/fireflies.cpp b/plugins/fireflies/src/fireflies.cpp
index bd3ae60..0e6c83a 100644
--- a/plugins/fireflies/src/fireflies.cpp
+++ b/plugins/fireflies/src/fireflies.cpp
@@ -104,9 +104,7 @@ FirefliesScreen::toggle (CompAction *action,
if (!p)
return true;
- options = p->vTable->getOptions ();
-
- foreach (CompOption opt, options)
+ foreach (CompOption &opt, p->vTable->getOptions ())
{
if (opt.type () == CompOption::TypeAction &&
opt.name () == "toggle_name")
diff --git a/plugins/snow/src/snow.cpp b/plugins/snow/src/snow.cpp
index 6fe379b..d382952 100644
--- a/plugins/snow/src/snow.cpp
+++ b/plugins/snow/src/snow.cpp
@@ -92,9 +92,7 @@ SnowScreen::toggle (CompAction *action,
if (!p)
return true;
- options = p->vTable->getOptions ();
-
- foreach (CompOption opt, options)
+ foreach (CompOption &opt, p->vTable->getOptions ())
{
if (opt.type () == CompOption::TypeAction &&
opt.name () == "toggle_name")
diff --git a/plugins/stars/src/stars.cpp b/plugins/stars/src/stars.cpp
index 41b3575..106a890 100644
--- a/plugins/stars/src/stars.cpp
+++ b/plugins/stars/src/stars.cpp
@@ -84,9 +84,7 @@ StarScreen::toggle (CompAction *action,
if (!p)
return true;
- options = p->vTable->getOptions ();
-
- foreach (CompOption opt, options)
+ foreach (CompOption &opt, p->vTable->getOptions ())
{
if (opt.type () == CompOption::TypeAction &&
opt.name () == "toggle_name")